-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DelegatedIdentity API clients to subscribe by PID #5272
Allow DelegatedIdentity API clients to subscribe by PID #5272
Conversation
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
fd38b74
to
c2f2f2c
Compare
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
@azdagron et al this end is now passing CI - PTAL at the |
(WAS passing until I resynced with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward. Just missing a few test cases. Thanks for the work, @bleggett!
Hey @bleggett! Just a friendly ping about addressing the comments. I think we're pretty close here! |
Signed-off-by: Benjamin Leggett <[email protected]>
Signed-off-by: Benjamin Leggett <[email protected]>
@azdagron everything should be addressed, lmk if you have further comments, ty! |
Signed-off-by: Benjamin Leggett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
ty all! |
Pull Request check list
Affected functionality
DelegateIdentity API
Description of change
This is the impl side of spiffe/spire-api-sdk#58
For this to build you need to locally check out thespire-api-sdk
fork @40d1bc186c2da087756115d9e6eb45e75aef0b3b as a sibling of this repo, so until/if that is merged, this should not be.CI will not pass until ☝️ happens!Ended up being simpler than I expected.
Note that docs and examples are pending still.Which issue this PR fixes
#5019